[asterisk-dev] [asterisk-commits] russell: trunk r97643 - /trunk/configure.ac

[Russell Bryant]

Luigi Rizzo wrote:
> On Wed, Jan 09, 2008 at 10:51:16PM -0000, SVN commits to the Asterisk project wrote:
>> Author: russell
>> Date: Wed Jan  9 16:51:15 2008
>> New Revision: 97643
>>
>> URL: http://svn.digium.com/view/asterisk?view=rev&rev=97643
>> Log:
>> re-add check for gtk1, which is used for pbx_gtkconsole
> 
> just to understand, what was the problem with the
> AST_EXT_TOOL_CHECK([GTK], [gtk])
> version ? Missing --cflags gthread or --libs gthread ?

I apologize for making this change so quickly without looking at
AST_EXT_TOOL_CHECK() closer.  But yes, it was missing "gthread".  After I
noticed that it wasn't working, I just copied the code that did work from 1.4.

> In case it would be preferable to expand the AST_EXT_TOOL_CHECK
> macro to include optional arguments (or maybe already does this)
> than to expand it inline in configure.ac

I agree that it makes sense to expand the macro and I will do so tomorrow.

> The comment "we don't use gtk right now..." is only to say
> that we make no use of the result of the check, but we do check.

It actually is used, though.  The results are used to compile pbx_gtkconsole.

Thanks for the feedback,

-- 
Russell Bryant
Senior Software Engineer
Open Source Team Lead
Digium, Inc.