[asterisk-dev] Re: [asterisk-commits] file: trunk r51831 - /trunk/main/manager.c

[Kevin P. Fleming]

asterisk-commits at lists.digium.com wrote:
> Author: file
> Date: Tue Jan 23 18:22:50 2007
> New Revision: 51831
> 
> URL: http://svn.digium.com/view/asterisk?view=rev&rev=51831
> Log:
> Close file after we do the translation, and map memory for both reading/writing. (issue #8886 reported by cwegener)

I'm curious as to why these changes were found necessary... we don't
write into the mmap-ed area, so PROT_WRITE should not be necessary.
Also, fclose() closes the 'FILE *' we opened on top of the fd, but
should not cause the fd to be closed underneath... so I don't understand
how moving the fclose() helped at all.

Obviously these are not big changes so I'm not asking for justification,
more out of curiosity :-)