[asterisk-dev] Re: [asterisk-commits] file: trunk r51831 - /trunk/main/manager.c

[Joshua Colp]

Kevin P. Fleming wrote:
> I'm curious as to why these changes were found necessary... we don't
> write into the mmap-ed area, so PROT_WRITE should not be necessary.

Not exactly true, there is at least a strsep which writes into the 
mmaped area.

> Also, fclose() closes the 'FILE *' we opened on top of the fd, but
> should not cause the fd to be closed underneath... so I don't understand
> how moving the fclose() helped at all.

Without moving the fclose the mmap would fail and everything would 
explode. Something must be happening underneath... or else I'm just crazy.

> Obviously these are not big changes so I'm not asking for justification,
> more out of curiosity :-)

Curiosity killed the internet connection! er wait no.