[asterisk-dev] Improvement of coding practices

[SF Markus Elfring]

> chan_zap.c breaks much more basic coding practices.
How many deisgners and software developers are working on this one?
http://svn.digium.com/view/asterisk/trunk/channels/chan_zap.c?rev=48767&view=markup

> That file is almost 400kB in size.
How many code areas are candidates to be split it into smaller parts?
http://en.wikipedia.org/wiki/Best_Coding_Practices

> It has tons of static (globals).
Can any of them be grouped into more independent modules?
http://en.wikipedia.org/wiki/Refactoring

> It has a very complex state machine with functions that range over hundreds lines.
Are any presentations or graphs available to review transitions and 
dependencies?
http://asterisk.org/developers/getting-started
http://en.wikipedia.org/wiki/State_diagram
http://en.wikipedia.org/wiki/Petri_net
http://en.wikipedia.org/wiki/Business_Process_Modeling_Notation
http://is.tm.tue.nl/research/patterns/patterns.htm

The links point to material that might be relevant in the discussed 
context, don't they?

Regards,
Markus