[Asterisk-Dev] Re: BOUNTY: app_hangup from exten => h

[Brian West]

I don't think this patch is one thats needed.  You can try all you want 
to keep stupid people from doing stupid things... Its still going to 
happen.

/b

On Apr 14, 2005, at 9:40 AM, Eric Wieling wrote:

> Andrew Kohlsmith wrote:
>
>> On April 14, 2005 10:01 am, Tony Mountifield wrote:
>>> There is no app_hangup.c. The Hangup command is implemented in pbx.c 
>>> by
>>> the function pbx_builtin_hangup(), which does nothing except return
>>> non-zero. The PBX core then initiates a hangup because the app 
>>> returned
>>> a non-zero status, which it would for ANY app that did so.
>>>
>>> In my opinion the correct fix would be for Asterisk, when an app 
>>> returns
>>> non-zero, to check if it has already called the h extension for the
>>> channel, and if so, NOT to go to h,1 again. This should be done using
>>> a flag rather than checking the extension, so that it still works if
>>> the dialplan does a Goto out of the h extension to somewhere else.
>> Have you ever seen Asterisk loop when Hangup is called from h?  I 
>> certainly never have...
>
> No, but I have seen many a time where people have exten => _.,Hangup 
> which is not a good thing most of the time.
>
>
> -- 
> Always do right. This will gratify some people and astonish the rest.
> Mark Twain
> _______________________________________________
> Asterisk-Dev mailing list
> Asterisk-Dev at lists.digium.com
> http://lists.digium.com/mailman/listinfo/asterisk-dev
> To UNSUBSCRIBE or update options visit:
>   http://lists.digium.com/mailman/listinfo/asterisk-dev