[Asterisk-Dev] app_disa2: Feedback requested

[John Todd]

>I'm working on rewriting app_disa and would like some feedback on my
>code.  I pretty much don't know what I'm doing, so any Asterisk specific
>comments would be greatly appreciated.  I'll try attaching the source,
>it's not all that big.  Yes, a fair number of features are not
>implemented (mostly password and config file features), but I wanted to
>see if I can get some feedback before I go much further with it.
>
>--Eric
>
[snip]

Eric -
   I'd suggest using the ResponseTimeout and DigitTimeout values as 
methods to check how long you should play the "dialtone" and then 
execute the dial statement.  Having a fixed timeout period is kind of 
ugly, which I believe is what is being used now.

   Additionally and closely related: it looks like this application 
does not have the option to be auto-completing to the context to 
which it is pointed.  In other words, if the context that you're 
sending these dialed strings into has "_1800XXXXXXX" as a matching 
possibility, will the number be dialed immediately after the user 
enters the last digit of 18005551212?  I'd like to see this as an 
option vs. a mandatory setting, since there are reasons to use either 
or both sometimes.  There should be "execute-on-timeout-only", 
"execute-on-match-only", and "execute-on-either" value settings, so 
that the administrator can determine when a number gets fed to the 
follow-up context.

   The "old" DISA application used to do immediate dials as soon as a 
match was found in the new context.  That was then modified by Mark 
some months ago and changed to just use a timeout (an overly long 
timeout, IMHO, but that's a minor and easily changed value.)  You may 
want to look at the DISA code from maybe March or so to check out 
what it used to do, and how you might integrate that into the new 
DISA package.

JT