[asterisk-commits] mjordan: trunk r349609 - in /trunk: ./ res/res_fax.c

[SVN commits to the Asterisk project]

Author: mjordan
Date: Wed Jan  4 15:40:45 2012
New Revision: 349609

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=349609
Log:
Free successfully translated frame in fax_gateway_framehook

A frame that is translated via ast_translate is also duplicated via ast_frdup.
This will allocate a new frame on the heap, which needs to be free'd
at the appropriate time.  This issue reporter used valgrind to find that this
occurred in res_fax's fax_gateway_framehook; a quick search through the code
showed that only place this was currently not handling the translatted frame
properly.

(closes issue ASTERISK-19133)
Reported by: Sylvain Rochet
........

Merged revisions 349608 from http://svn.asterisk.org/svn/asterisk/branches/10

Modified:
    trunk/   (props changed)
    trunk/res/res_fax.c

Propchange: trunk/
------------------------------------------------------------------------------
Binary property 'branch-10-merged' - no diff available.

Modified: trunk/res/res_fax.c
URL: http://svnview.digium.com/svn/asterisk/trunk/res/res_fax.c?view=diff&rev=349609&r1=349608&r2=349609
==============================================================================
--- trunk/res/res_fax.c (original)
+++ trunk/res/res_fax.c Wed Jan  4 15:40:45 2012
@@ -3086,6 +3086,7 @@
 		 * write would fail, or even if a failure would be fatal so for
 		 * now we'll just ignore the return value. */
 		gateway->s->tech->write(gateway->s, f);
+		ast_frfree(f);
 		f = &ast_null_frame;
 		ao2_ref(details, -1);
 		return f;