[asterisk-commits] mjordan: branch 10 r349619 - /branches/10/apps/confbridge/conf_config_parser.c

[SVN commits to the Asterisk project]

Author: mjordan
Date: Wed Jan  4 16:19:34 2012
New Revision: 349619

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=349619
Log:
Fix for ConfBridge config parser unlocking channel mutex too many times

When looking up a ConfBridge profile, the config parser would, if it
found a channel datastore on the channel requesting the bridge profile,
unlock the channel mutex twice.  Since that's a little aggressive,
it now only unlocks it once.

(closes issue ASTERISK-19042)
Reported by: Matt Jordan
Tested by: Matt Jordan
Patches: 
  19042 uploaded by David Vossel (license 5628)


Modified:
    branches/10/apps/confbridge/conf_config_parser.c

Modified: branches/10/apps/confbridge/conf_config_parser.c
URL: http://svnview.digium.com/svn/asterisk/branches/10/apps/confbridge/conf_config_parser.c?view=diff&rev=349619&r1=349618&r2=349619
==============================================================================
--- branches/10/apps/confbridge/conf_config_parser.c (original)
+++ branches/10/apps/confbridge/conf_config_parser.c Wed Jan  4 16:19:34 2012
@@ -1312,8 +1312,9 @@
 				conf_user_profile_copy(result, &b_data->u_profile);
 				return result;
 			}
-		}
-		ast_channel_unlock(chan);
+		} else {
+			ast_channel_unlock(chan);
+		}
 	}
 
 	if (ast_strlen_zero(user_profile_name)) {
@@ -1362,8 +1363,9 @@
 				conf_bridge_profile_copy(result, &b_data->b_profile);
 				return result;
 			}
-		}
-		ast_channel_unlock(chan);
+		} else {
+			ast_channel_unlock(chan);
+		}
 	}
 	if (ast_strlen_zero(bridge_profile_name)) {
 		bridge_profile_name = DEFAULT_BRIDGE_PROFILE;