[asterisk-commits] mjordan: branch 10 r349608 - /branches/10/res/res_fax.c

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Wed Jan 4 15:40:02 CST 2012


Author: mjordan
Date: Wed Jan  4 15:39:59 2012
New Revision: 349608

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=349608
Log:
Free successfully translated frame in fax_gateway_framehook

A frame that is translated via ast_translate is also duplicated via ast_frdup.
This will allocate a new frame on the heap, which needs to be free'd
at the appropriate time.  This issue reporter used valgrind to find that this
occurred in res_fax's fax_gateway_framehook; a quick search through the code
showed that only place this was currently not handling the translatted frame
properly.

(closes issue ASTERISK-19133)
Reported by: Sylvain Rochet


Modified:
    branches/10/res/res_fax.c

Modified: branches/10/res/res_fax.c
URL: http://svnview.digium.com/svn/asterisk/branches/10/res/res_fax.c?view=diff&rev=349608&r1=349607&r2=349608
==============================================================================
--- branches/10/res/res_fax.c (original)
+++ branches/10/res/res_fax.c Wed Jan  4 15:39:59 2012
@@ -3058,6 +3058,7 @@
 		 * write would fail, or even if a failure would be fatal so for
 		 * now we'll just ignore the return value. */
 		gateway->s->tech->write(gateway->s, f);
+		ast_frfree(f);
 		f = &ast_null_frame;
 		ao2_ref(details, -1);
 		return f;




More information about the asterisk-commits mailing list