[Asterisk-code-review] res_monitor: Remove deprecated module. (asterisk[master])

N A asteriskteam at digium.com
Wed Jan 4 05:22:58 CST 2023


Attention is currently required from: Michael Bradeen.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19605 )

Change subject: res_monitor: Remove deprecated module.
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

Patchset:

PS5: 
This will fail:

ast_pbx_exec_application(monitor_chan, "Monitor", monitor_args);

bridge_check_monitor can be removed entirely from features.c



main/features.c:static void bridge_check_monitor(struct ast_channel *chan, struct ast_channel *peer)
main/features.c:        const char *monitor_args = NULL;
main/features.c:        struct ast_channel *monitor_chan = NULL;
main/features.c:                monitor_args = ast_strdupa(value);
main/features.c:                monitor_chan = chan;
main/features.c:        if (!monitor_chan) {
main/features.c:                        monitor_args = ast_strdupa(value);
main/features.c:                        monitor_chan = peer;
main/features.c:        if (monitor_chan) {
main/features.c:                ast_pbx_exec_application(monitor_chan, "Monitor", monitor_args);



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19605
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I0462caefb4f9544e2e2baa23c498858310b52d50
Gerrit-Change-Number: 19605
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Wed, 04 Jan 2023 11:22:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230104/fdcaba02/attachment-0001.html>


More information about the asterisk-code-review mailing list