<p> Attention is currently required from: Michael Bradeen. </p>
<p>Patch set 5:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/19605">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/19605?tab=comments">Patch Set #5:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">This will fail:</p><p style="white-space: pre-wrap; word-wrap: break-word;">ast_pbx_exec_application(monitor_chan, "Monitor", monitor_args);</p><p style="white-space: pre-wrap; word-wrap: break-word;">bridge_check_monitor can be removed entirely from features.c</p><p style="white-space: pre-wrap; word-wrap: break-word;">main/features.c:static void bridge_check_monitor(struct ast_channel *chan, struct ast_channel *peer)<br>main/features.c: const char *monitor_args = NULL;<br>main/features.c: struct ast_channel *monitor_chan = NULL;<br>main/features.c: monitor_args = ast_strdupa(value);<br>main/features.c: monitor_chan = chan;<br>main/features.c: if (!monitor_chan) {<br>main/features.c: monitor_args = ast_strdupa(value);<br>main/features.c: monitor_chan = peer;<br>main/features.c: if (monitor_chan) {<br>main/features.c: ast_pbx_exec_application(monitor_chan, "Monitor", monitor_args);</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/19605">change 19605</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/19605"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0462caefb4f9544e2e2baa23c498858310b52d50 </div>
<div style="display:none"> Gerrit-Change-Number: 19605 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 04 Jan 2023 11:22:58 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>