[Asterisk-code-review] res_monitor: Remove deprecated module. (asterisk[master])

Michael Bradeen asteriskteam at digium.com
Tue Jan 3 16:33:15 CST 2023


Attention is currently required from: N A.

Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19605 )

Change subject: res_monitor: Remove deprecated module.
......................................................................


Patch Set 5:

(3 comments)

File bridges/bridge_builtin_features.c:

https://gerrit.asterisk.org/c/asterisk/+/19605/comment/651b6682_52703c49 
PS3, Line 92: 	}
> Since the else was always res_monitor stuff, isn't "is_mixmonitor" always true here now?
Done


File configs/samples/queues.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19605/comment/0f408c22_484dde90 
PS3, Line 31: ;    monitor-type = MixMonitor is the only currently supported ption.
> option
Done


File configs/samples/sip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19605/comment/c41fe48e_588e1f5a 
PS3, Line 158:  
> option should be singular here and below
this file was ultimately removed before this change, so this particular comment no longer applies.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19605
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I0462caefb4f9544e2e2baa23c498858310b52d50
Gerrit-Change-Number: 19605
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Tue, 03 Jan 2023 22:33:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230103/7dc0fdff/attachment.html>


More information about the asterisk-code-review mailing list