[Asterisk-code-review] res_pjsip: Add 100rel option "peer_supported". (asterisk[16])

[Ivan Poddubny]

Attention is currently required from: Joshua Colp, N A, George Joseph, Maximilian Fridrich.

Ivan Poddubny has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18838 )

Change subject: res_pjsip: Add 100rel option "peer_supported".
......................................................................


Patch Set 6:

(1 comment)

Patchset:

PS6: 
> I'm hesitant to change any behavior. […]
In this case I think that having 3 options is simple and clean: no (=never), yes (=used when supported by both), required (=always). This way these descriptions apply to both UAS and UAC, consistently. What is currently called "yes" behaves weird. For instance, connect 2 Asterisks with PJSIP and use "100rel=yes" in endpoints on both nodes: 100rel won't be used. I'd call it a bug.

I can't imagine a case when this change may cause issues (if UAC declares support for 100rel in INVITE, it must certainly be ready to use it?), but in case the old behavior is ever needed, it's always possible to re-introduce it as a new option.

I understand there's some risk in changing behavior. On the other hand, there's also a risk of introducing this incidental complexity into Asterisk that will most likely stay there forever, because deleting options is a lot harder than introducing them.
Maybe it's worth gathering more feedback (asterisk-dev, asterisk-users?) before merging the patch?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18838
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id6d95ffa8f00dab118e0b386146e99f254f287ad
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 6
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Comment-Date: Thu, 15 Sep 2022 07:56:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220915/6f7670b1/attachment.html>