[Asterisk-code-review] res_pjsip: Add 100rel option "peer_supported". (asterisk[16])

[Maximilian Fridrich]

Attention is currently required from: Joshua Colp, N A, Ivan Poddubny, George Joseph.

Maximilian Fridrich has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18838 )

Change subject: res_pjsip: Add 100rel option "peer_supported".
......................................................................


Patch Set 6:

(1 comment)

Patchset:

PS6: 
> In this case I think that having 3 options is simple and clean: no (=never), yes (=used when support […]
Indicating support for 100rel but not using it is certainly not a bug - as RFC 3262 confirms. It is up to the UA to require 100rel support or (as UAS) use it if the other side indicated its support - which is what the "peer_supported" achieves.

Our motivation for adding this option is because we want to do session modifications (using UPDATEs) while the dialog is still in the early state. This is only possible if we have sent our 1xx responses reliably - see RFC 6337 (section 3.2).

And I understand the maintainer's position to not change existing behavior - I feel like having a "better safe than sorry" attitude has served the stability of Asterisk well.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18838
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id6d95ffa8f00dab118e0b386146e99f254f287ad
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 6
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 15 Sep 2022 08:12:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220915/47489eb3/attachment.html>