[Asterisk-code-review] res_pjsip: Add 100rel option "peer_supported". (asterisk[16])

Joshua Colp asteriskteam at digium.com
Wed Sep 14 07:37:53 CDT 2022


Attention is currently required from: N A, Ivan Poddubny, George Joseph, Maximilian Fridrich.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18838 )

Change subject: res_pjsip: Add 100rel option "peer_supported".
......................................................................


Patch Set 6:

(1 comment)

Patchset:

PS6: 
> Does it make sense to keep the current 100rel=yes behavior, namely that when Asterisk with a "100rel […]
I'm hesitant to change any behavior. While changing behavior can have the best of intentions, we've been bitten by it previously.

I also don't consider what you link the "reference implementation". It's AN implementation and has its own behavior with various things.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18838
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id6d95ffa8f00dab118e0b386146e99f254f287ad
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 6
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 12:37:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220914/25f82584/attachment-0001.html>


More information about the asterisk-code-review mailing list