[Asterisk-code-review] res_pjsip: Add 100rel option "peer_supported". (asterisk[16])

[Ivan Poddubny]

Attention is currently required from: N A, George Joseph, Maximilian Fridrich.

Ivan Poddubny has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18838 )

Change subject: res_pjsip: Add 100rel option "peer_supported".
......................................................................


Patch Set 6:

(1 comment)

Patchset:

PS6: 
Does it make sense to keep the current 100rel=yes behavior, namely that when Asterisk with a "100rel=yes" endpoint gets an incoming INVITE with "Supported: 100rel", 100rel is *not* used? In my opinion, the expected behavior for 2 parties both claiming to support 100rel is to use 100rel. If so, the scope of the change gets smaller, the ABI compatibility is preserved (extending ast_sip_session breaks it), so it can be merged into all maintained release branches, and what is most important, Asterisk doesn't get unnecessary complexity in the source code and from the end user perspective.

Also, look at the reference 100rel UAS implementation in pjproject: "If 100rel is optional and UAC supports it, use it."
https://github.com/chakrit/pjsip/blob/master/pjsip/src/pjsua-lib/pjsua_call.c#L1311-L1322



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18838
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id6d95ffa8f00dab118e0b386146e99f254f287ad
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 6
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 12:32:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220914/726458fb/attachment.html>