[Asterisk-code-review] res_pjsip: return all codecs on a re-INVITE without SDP (asterisk[16])

[Joshua Colp]

Attention is currently required from: N A, Henning Westerholt.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18990 )

Change subject: res_pjsip: return all codecs on a re-INVITE without SDP
......................................................................


Patch Set 6: Code-Review-1

(4 comments)

Patchset:

PS6: 
For release branches we refrain from changing default behavior unless absolutely needed. This should default to previous behavior.


File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/14bce86a_096f7801 
PS6, Line 1286: ;all_codecs_on_empty_reinvite=yes
This should state what the default behavior is.


File res/res_pjsip/config_global.c:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/49d94bae_f61b55f1 
PS6, Line 57: #define DEFAULT_ALL_CODECS_ON_EMPTY_REINVITE 1
Default behavior should remain as it was.


File res/res_pjsip/pjsip_config.xml:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/75191478_5f8d4cf2 
PS6, Line 2104: 				<configOption name="all_codecs_on_empty_reinvite" default="yes">
Default should be no.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18990
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I69763708d5039d512f391e296ee8a4d43a1e2148
Gerrit-Change-Number: 18990
Gerrit-PatchSet: 6
Gerrit-Owner: Henning Westerholt <hw at gilawa.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Henning Westerholt <hw at gilawa.com>
Gerrit-Comment-Date: Mon, 10 Oct 2022 12:08:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221010/4f66aa24/attachment.html>