<p> Attention is currently required from: N A, Henning Westerholt. </p>
<p>Patch set 6:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18990">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990?tab=comments">Patch Set #6:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">For release branches we refrain from changing default behavior unless absolutely needed. This should default to previous behavior.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/pjsip.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/14bce86a_096f7801">Patch Set #6, Line 1286:</a> <code style="font-family:monospace,monospace">;all_codecs_on_empty_reinvite=yes</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should state what the default behavior is.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip/config_global.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/49d94bae_f61b55f1">Patch Set #6, Line 57:</a> <code style="font-family:monospace,monospace">#define DEFAULT_ALL_CODECS_ON_EMPTY_REINVITE 1</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Default behavior should remain as it was.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip/pjsip_config.xml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18990/comment/75191478_5f8d4cf2">Patch Set #6, Line 2104:</a> <code style="font-family:monospace,monospace">                         <configOption name="all_codecs_on_empty_reinvite" default="yes"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Default should be no.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18990">change 18990</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18990"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I69763708d5039d512f391e296ee8a4d43a1e2148 </div>
<div style="display:none"> Gerrit-Change-Number: 18990 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: Henning Westerholt <hw@gilawa.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: Henning Westerholt <hw@gilawa.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 10 Oct 2022 12:08:12 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>