[Asterisk-code-review] res_pjsip: return all codecs on a re-INVITE without SDP (asterisk[16])

[George Joseph]

Attention is currently required from: N A, Henning Westerholt.

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18990 )

Change subject: res_pjsip: return all codecs on a re-INVITE without SDP
......................................................................


Patch Set 6: Code-Review-1

(13 comments)

File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/c7be6afe_03877142 
PS6, Line 1287:                     ; On reception of a re-INVITE without SDP Asterisk will send an SDP
You should indicate the default value.


File doc/CHANGES-staging/res_pjsip_all_codecs_on_empty_reinvite_option.txt:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/73c7d198_40deaf02 
PS6, Line 3: A new option named "all_codecs_on_empty_reinvite" has been added to the
You should indicate the default value.


File res/res_pjsip/config_global.c:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/018a7ecc_1b92d0cd 
PS6, Line 57: #define DEFAULT_ALL_CODECS_ON_EMPTY_REINVITE 1
I think the default should be 0 to preserve existing behavior.


File res/res_pjsip/pjsip_config.xml:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/36976504_4e60a8b2 
PS6, Line 2104: yes
Should be "no".


File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/ce7343b1_2f503f7f 
PS6, Line 5078: 1
Since the SCOPE_ENTER for this function uses level 3, this should be either -1 to use the same level, or a number >= 3.  Otherwise these trace messages will show up when "core set trace 1" is used but the corresponding SCOPE_ENTER and SCOPE_EXIT messages won't.  I usually use a level that's 1 > than the SCOPE level for ast_trace statements and if they're in a loop, 2 >.


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/e0264207_d2fb6c1e 
PS6, Line 5081: 1
same


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/03e45bd5_ab222ff5 
PS6, Line 5085: 1
same


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/f7dbe064_ff647f37 
PS6, Line 5087: 1
same


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/7f9d8c55_a6450c6c 
PS6, Line 5244: 	ast_trace(1, "session_inv_on_create_offer\n");
You don't need an ast_trace here since the SCOPE_ENTER prints the same message.  You should also move the SCOPE_ENTER above the comment.


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/655d5a6e_78276df0 
PS6, Line 5246: 		return;
Replace this return with SCOPE_EXIT_RTN("%s: No channel\n", ast_sip_session_get_name(session));  SCOPE_ENTER always needs to be balanced with a SCOPE_EXIT.


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/7c441ab0_9ede8f60 
PS6, Line 5256: 1
See above comment about trace level.


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/4875377f_3643e61e 
PS6, Line 5259: 1
Same


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/007b8a14_6dbb14ff 
PS6, Line 5279: 		return;
You can remove the return since that's what SCOPE_EXIT_RTN does.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18990
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I69763708d5039d512f391e296ee8a4d43a1e2148
Gerrit-Change-Number: 18990
Gerrit-PatchSet: 6
Gerrit-Owner: Henning Westerholt <hw at gilawa.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Henning Westerholt <hw at gilawa.com>
Gerrit-Comment-Date: Mon, 10 Oct 2022 12:10:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221010/176f17a9/attachment-0001.html>