[Asterisk-code-review] res_pjsip_header_funcs: Add functions PJSIP_RESPONSE_HEADER and PJSIP... (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A, José Lopes.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18367 )

Change subject: res_pjsip_header_funcs: Add functions PJSIP_RESPONSE_HEADER and PJSIP_RESPONSE_HEADERS
......................................................................


Patch Set 4: Code-Review-1

(4 comments)

File doc/CHANGES-staging/res_pjsip_header_funcs.txt:

https://gerrit.asterisk.org/c/asterisk/+/18367/comment/99bbee7c_f50cb802 
PS4, Line 3: Add function PJSIP_RESPONSE_HEADERS() to get list of response headers by pattern in the same way as PJSIP_HEADERS() for request headers.
This should specify that it is for headers from 200 response.


File res/res_pjsip_header_funcs.c:

https://gerrit.asterisk.org/c/asterisk/+/18367/comment/684423ea_8d154dfe 
PS4, Line 173: 			Gets headers of 2xx response from an outbound PJSIP channel.
There's conflicting comments in this issue. In some places you say 200, here you say 2xx. They should all be the same.


https://gerrit.asterisk.org/c/asterisk/+/18367/comment/0369a54e_ff220eaa 
PS4, Line 350: 	// Skip responses before 2xx OK
We use /* and */ for comments


https://gerrit.asterisk.org/c/asterisk/+/18367/comment/ef7b513a_674d859f 
PS4, Line 351: 	if (session->inv_session->state < PJSIP_INV_STATE_CONNECTING) {
I think it would be better to instead look at the response code and limit it to 2xx class instead.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18367
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I264a610a9333359297a0825feb29a1bb4f4ad144
Gerrit-Change-Number: 18367
Gerrit-PatchSet: 4
Gerrit-Owner: José Lopes <jose.lopes at nfon.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: José Lopes <jose.lopes at nfon.com>
Gerrit-Comment-Date: Thu, 26 May 2022 11:52:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220526/574e6d90/attachment-0001.html>