[Asterisk-code-review] res_ari_channels/res_pjsip: Added test for exposed protocol_id (testsuite[master])

Joshua Colp asteriskteam at digium.com
Wed May 11 05:28:57 CDT 2022


Attention is currently required from: Michael Bradeen, Moritz Fain.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/18418 )

Change subject: res_ari_channels/res_pjsip: Added test for exposed protocol_id
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

Patchset:

PS3: 
This test actually originates quite a number of channels, when in reality only one is really needed. A better basis for this would be the originate_with_id test, trimming it down to a single test iteration.


File tests/rest_api/channels/originate_to_pjsip_endpoint/channel_originate.py:

https://gerrit.asterisk.org/c/testsuite/+/18418/comment/d56927c1_105ce987 
PS3, Line 18:     for x in xrange(15):
This specific test doesn't need to originate 15 channels, one is good enough.



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/18418
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: Ibc8a103b9e54d709aa39472fa2d77a969c1685ac
Gerrit-Change-Number: 18418
Gerrit-PatchSet: 3
Gerrit-Owner: Moritz Fain <moritz at fain.io>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Moritz Fain <moritz at fain.io>
Gerrit-Comment-Date: Wed, 11 May 2022 10:28:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220511/272f86b0/attachment.html>


More information about the asterisk-code-review mailing list