[Asterisk-code-review] res_pjsip_header_funcs: Add functions PJSIP_RESPONSE_HEADER and PJSIP... (asterisk[master])

[José Lopes]

Attention is currently required from: Joshua Colp, N A.
José Lopes has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18367 )

Change subject: res_pjsip_header_funcs: Add functions PJSIP_RESPONSE_HEADER and PJSIP_RESPONSE_HEADERS
......................................................................


Patch Set 4:

(6 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18367/comment/abec006d_cf1e5905 
PS3, Line 7: res_pjsip_header_funcs: Add functions PJSIP_REPLY_HEADER and PJSIP_REPLY_HEADERS
> In SIP this is called a response, not a reply. […]
Done


Patchset:

PS3: 
> This also needs a CHANGES entry[1]. […]
I added an entry on CHANGES.


Patchset:

PS4: 
Thanks for your feedback.
I updated the commit.
Let me know if it is necessary anything more.


File res/res_pjsip_reply_header_funcs.c:

https://gerrit.asterisk.org/c/asterisk/+/18367/comment/8f8b0847_1420d5b6 
PS3, Line 111: 			INVITE reply message. Multiple headers with the same name are included in the list only once.
> What happens if there are multiple responses? The behavior should be documented
I am only getting headers from 2xx Response. I updated the documentation with that.


https://gerrit.asterisk.org/c/asterisk/+/18367/comment/21f4c8c3_42370f49 
PS3, Line 138: /*! \brief Data structure used for ast_sip_push_task_wait_serializer  */
> This duplicates a lot of the code from res_pjsip_header_funcs, I think it should just be part of tha […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18367/comment/87a718cb_a9c1c196 
PS3, Line 184: 	if (session->inv_session->state <= PJSIP_INV_STATE_EARLY) {
> Document why PJSIP_INV_STATE_EARLY
I added a comment there and also documented that we only check 2xx response headers.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18367
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I264a610a9333359297a0825feb29a1bb4f4ad144
Gerrit-Change-Number: 18367
Gerrit-PatchSet: 4
Gerrit-Owner: José Lopes <jose.lopes at nfon.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 11 May 2022 10:30:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220511/25493772/attachment.html>