[Asterisk-code-review] res_pjsip_outbound_registration: Make max random delay configurable. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18195 )

Change subject: res_pjsip_outbound_registration: Make max random delay configurable.
......................................................................


Patch Set 1:

(2 comments)

File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/c/asterisk/+/18195/comment/92bde092_a1b99a6c 
PS1, Line 112: 				<configOption name="max_random_delay" default="10">
> This needs an Alembic migration script[1]. These are in contrib/ast-db-manage/ […]
Would I add this to the existing script for outbound registration or is it a new script for new things that are added?


https://gerrit.asterisk.org/c/asterisk/+/18195/comment/39675cfb_ce65d7cf 
PS1, Line 1743: 	max_delay = registration->max_random_delay;
> Why do you get the max_random_delay value if you still have registration below during schedule_regis […]
I'm not sure I fully understand, can you clarify what you mean by this? Only max_delay is passed in as an arg to schedule_registration.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18195
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iab989a8e94323e645f3a21cbb6082287c7b2f3fd
Gerrit-Change-Number: 18195
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 18 Mar 2022 11:58:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220318/bcab4277/attachment.html>