[Asterisk-code-review] res_pjsip_outbound_registration: Make max random delay configurable. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18195 )

Change subject: res_pjsip_outbound_registration: Make max random delay configurable.
......................................................................


Patch Set 1:

(2 comments)

File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/c/asterisk/+/18195/comment/c4ca379d_9cd7b216 
PS1, Line 112: 				<configOption name="max_random_delay" default="10">
> Would I add this to the existing script for outbound registration or is it a new script for new thin […]
It's a new script. If you add something new, it's a new migration.


https://gerrit.asterisk.org/c/asterisk/+/18195/comment/980625cb_52fd41ed 
PS1, Line 1743: 	max_delay = registration->max_random_delay;
> I'm not sure I fully understand, can you clarify what you mean by this? Only max_delay is passed in  […]
Right - but why do you retrieve the value and store it in max_delay? Why don't you just use registration->max_random_delay in schedule_registration?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18195
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iab989a8e94323e645f3a21cbb6082287c7b2f3fd
Gerrit-Change-Number: 18195
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Fri, 18 Mar 2022 12:22:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220318/34a83bd5/attachment.html>