[Asterisk-code-review] res_pjsip_outbound_registration: Make max random delay configurable. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18195 )

Change subject: res_pjsip_outbound_registration: Make max random delay configurable.
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18195/comment/7ca91aea_bb9b296b 
PS1, Line 14: This can create limitations with the test suite where we need to
I don't understand this. Are you referring to testing outbound registration or something? What test failures are you referring to?


File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18195/comment/2cce7bcf_62e119a2 
PS1, Line 1345: ;max_random_delay=10    ; Maximum random delay for initial registrations (default: 10)
Document why this behavior even exists, as you've done in the commit message, and the ramifications of changing it to a lower value.


File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/c/asterisk/+/18195/comment/4cddc3c8_8b72466b 
PS1, Line 112: 				<configOption name="max_random_delay" default="10">
This needs an Alembic migration script[1]. These are in contrib/ast-db-manage/

[1] https://alembic.sqlalchemy.org/en/latest/tutorial.html#create-a-migration-script


https://gerrit.asterisk.org/c/asterisk/+/18195/comment/dba97c57_366f23d0 
PS1, Line 1743: 	max_delay = registration->max_random_delay;
Why do you get the max_random_delay value if you still have registration below during schedule_registration?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18195
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iab989a8e94323e645f3a21cbb6082287c7b2f3fd
Gerrit-Change-Number: 18195
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 15 Mar 2022 10:53:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220315/a95f7d9b/attachment.html>