[Asterisk-code-review] chan_pjsip: Add option to not play music on hold on unanswered channels (asterisk[master])

Sean Bright asteriskteam at digium.com
Tue Jul 26 09:56:58 CDT 2022


Attention is currently required from: sungtae kim, N A, Joshua Colp, Kevin Harwell.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18781 )

Change subject: chan_pjsip: Add option to not play music on hold on unanswered channels
......................................................................


Patch Set 9:

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18781/comment/7f535b4d_68b3b7eb 
PS8, Line 10: will process the hold request for the answered channel only.
> Per earlier feedback, change the commit message to be clearer. Right now it is not accurate. […]
Done


File doc/CHANGES-staging/res_pjsip_moh_answeredonly.txt:

https://gerrit.asterisk.org/c/asterisk/+/18781/comment/e966310b_f7dea7ce 
PS8, Line 3: Add moh_answeredonly pjsip option to allow the moh only for the answered channel.
> Same comment as for the commit message: change the verbiage to match what you did in the config file […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18781
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3c9b9101e4dc85338154b8004cecdd3edc227474
Gerrit-Change-Number: 18781
Gerrit-PatchSet: 9
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: sungtae kim <pchero21 at gmail.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <default.enum at gmail.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 14:56:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220726/bb9c6e32/attachment-0001.html>


More information about the asterisk-code-review mailing list