[Asterisk-code-review] chan_pjsip: Add option to not play music on hold on unanswered channels (asterisk[master])

[Joshua Colp]

Attention is currently required from: sungtae kim, Sean Bright, N A, Kevin Harwell.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18781 )

Change subject: chan_pjsip: Add option to not play music on hold on unanswered channels
......................................................................


Patch Set 9: Code-Review-1

(2 comments)

File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/18781/comment/ce753b1c_117c81fc 
PS9, Line 1772: 					ast_sorcery_object_get_id(channel->session),
Sessions aren't a sorcery object, you can't get the id of them. Channel name would be better.


File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/c/asterisk/+/18781/comment/c1f722a7_894a2f17 
PS9, Line 934: 	/*! Only allow answered channels to have music on hold. Enabling this will prevent MOH on unanswered channels. */
This should go at the end of the structure



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18781
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3c9b9101e4dc85338154b8004cecdd3edc227474
Gerrit-Change-Number: 18781
Gerrit-PatchSet: 9
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: sungtae kim <pchero21 at gmail.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Kevin Harwell <default.enum at gmail.com>
Gerrit-Comment-Date: Thu, 28 Jul 2022 09:03:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220728/c52c883e/attachment-0001.html>