[Asterisk-code-review] chan_pjsip: Add option to not play music on hold on unanswered channels (asterisk[master])

[N A]

Attention is currently required from: sungtae kim, Sean Bright, Joshua Colp, Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18781 )

Change subject: chan_pjsip: Add option to not play music on hold on unanswered channels
......................................................................


Patch Set 8: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18781/comment/13fa9e02_437d7889 
PS8, Line 10: will process the hold request for the answered channel only.
Per earlier feedback, change the commit message to be clearer. Right now it is not accurate.

e.g. "Adds an option to allow only answered channels to have music on hold. Enabling this will prevent MOH on unanswered channels."


File doc/CHANGES-staging/res_pjsip_moh_answeredonly.txt:

https://gerrit.asterisk.org/c/asterisk/+/18781/comment/f6908c04_8df91964 
PS8, Line 3: Add moh_answeredonly pjsip option to allow the moh only for the answered channel.
Same comment as for the commit message: change the verbiage to match what you did in the config file.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18781
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3c9b9101e4dc85338154b8004cecdd3edc227474
Gerrit-Change-Number: 18781
Gerrit-PatchSet: 8
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: sungtae kim <pchero21 at gmail.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <default.enum at gmail.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 14:10:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220726/826e48b1/attachment.html>