[Asterisk-code-review] chan_pjsip: Add option to not play music on hold on unanswered channels (asterisk[master])

[sungtae kim]

Attention is currently required from: Sean Bright, Joshua Colp, N A, Kevin Harwell.
sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18781 )

Change subject: chan_pjsip: Add option to not play music on hold on unanswered channels
......................................................................


Patch Set 8:

(4 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18781/comment/eaa9939f_3ba00811 
PS6, Line 9: This change adds an option, moh_answeredonly, that when enabled will
> Oh, Got it. […]
Done


File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/18781/comment/27eee895_6b682b9f 
PS6, Line 1770: 		if (channel->session->moh_answeredonly && (ast_channel_state(ast) == AST_STATE_UP)) {
> Oh my... Thanks. I fixed it.
Done


File res/res_pjsip/pjsip_config.xml:

https://gerrit.asterisk.org/c/asterisk/+/18781/comment/ade9fcb8_9914ff9e 
PS7, Line 947: Allows the only answered channel able to be music on hold
> Thanks! I fixed it. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18781/comment/80c3f23b_7c9ca001 
PS7, Line 947: Allows the only answered channel able to be music on hold
> Thanks! I fixed it. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18781
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3c9b9101e4dc85338154b8004cecdd3edc227474
Gerrit-Change-Number: 18781
Gerrit-PatchSet: 8
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Kevin Harwell <default.enum at gmail.com>
Gerrit-Comment-Date: Mon, 25 Jul 2022 17:03:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: sungtae kim <pchero21 at gmail.com>
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220725/60833cdf/attachment.html>