[Asterisk-code-review] Geolocation: Core Capability Preview (asterisk[16])

[Kevin Harwell]

Attention is currently required from: George Joseph.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18696 )

Change subject: Geolocation:  Core Capability Preview
......................................................................


Patch Set 1: Code-Review-1

(24 comments)

File configs/samples/geolocation.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18696/comment/be3355b3_4a1e82dd 
PS1, Line 183: propogated
s/propogated/propagated


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/4aa7e69a_c5686753 
PS1, Line 186: propogated
s/propogated/propagated


File res/res_geolocation/eprofile_to_pidf.xslt:

https://gerrit.asterisk.org/c/asterisk/+/18696/comment/c415aac4_4e3452eb 
PS1, Line 12: 	
Whitespace


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/65160aac_3e4704d4 
PS1, Line 91: 		
Whitespace


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/a3b1f9bd_f2b9d56e 
PS1, Line 97: 		
Whitespace


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/b3665013_dc670491 
PS1, Line 117: 	
Whitespace


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/27ed3ee8_1bb06956 
PS1, Line 133: 		</xsl:element>	
Whitespace eol


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/91322000_8a6a438c 
PS1, Line 191: 	
Whitespace


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/791cf58a_245e0135 
PS1, Line 222: 	
Whitespace


File res/res_geolocation/geoloc_doc.xml:

https://gerrit.asterisk.org/c/asterisk/+/18696/comment/18d486db_d7d77c33 
PS1, Line 141: 						<para>The specification of this parameter will cause a 
eol whitespace


File res/res_geolocation/geoloc_eprofile.c:

https://gerrit.asterisk.org/c/asterisk/+/18696/comment/b87380c0_054cde6c 
PS1, Line 390: 	dup = ast_strdupa(ast_str_buffer(buf));
This appears to dupe the string just for debug/scope logging. Could probably avoid the string copy if you used a RAII_VAR on buf.


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/69cde760_1014c79e 
PS1, Line 430: 	dup = ast_strdupa(ast_str_buffer(buf));
Same here. Using an RAII_VAR on buf should avoid the string copy.


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/625f57f8_660c69b1 
PS1, Line 845: //		geoloc_eprofile_unload();
Seems like this line should not be commented out?


File res/res_geolocation/pidf_to_eprofile.xslt:

https://gerrit.asterisk.org/c/asterisk/+/18696/comment/06b57033_76f2d096 
PS1, Line 19: 	
Whitespace


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/d1e47e9d_39d5c0e6 
PS1, Line 27: 	
Whitespace


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/a36b6907_d3cc31d9 
PS1, Line 30: -->	
Whitespace


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/d44b9413_417c4ba8 
PS1, Line 34: cound
s/cound/could


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/4b23c378_33913be3 
PS1, Line 39: 	"dm:device" would match "pdm:device" in the document. 
whitespace


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/2d7d46d2_b6e5f9ac 
PS1, Line 41: 	
Whitespace


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/63ed226f_d872f5e0 
PS1, Line 45: 	
Whitespace


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/7cc19bb5_5ec341fd 
PS1, Line 50: 		
Whitespace


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/9a12db44_6afed1f6 
PS1, Line 134: 		
Whitespace


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/b4cdecda_4883e71a 
PS1, Line 156: 	
Whitespace


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/6c4ffabf_95c2bf04 
PS1, Line 211: 	
Whitespace



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18696
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ibfde963121b1ecf57fd98ee7060c4f0808416303
Gerrit-Change-Number: 18696
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 06 Jul 2022 21:38:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220706/c80ce69c/attachment-0001.html>