[Asterisk-code-review] Geolocation: Core Capability Preview (asterisk[16])

[George Joseph]

Attention is currently required from: Stanislav Abramenkov, Kevin Harwell.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18696 )

Change subject: Geolocation:  Core Capability Preview
......................................................................


Patch Set 1:

(25 comments)

File configs/samples/geolocation.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18696/comment/04167caf_deb09dd4 
PS1, Line 183: propogated
> s/propogated/propagated
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/0100c8d3_1bf0d6df 
PS1, Line 186: propogated
> s/propogated/propagated
Done


File res/res_geolocation/eprofile_to_pidf.xslt:

https://gerrit.asterisk.org/c/asterisk/+/18696/comment/dec0fc96_60f4d198 
PS1, Line 12: 	
> Whitespace
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/718bd08e_0f007ebd 
PS1, Line 91: 		
> Whitespace
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/5b36a46b_e501b85c 
PS1, Line 97: 		
> Whitespace
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/a8b7b0f6_3c98ce73 
PS1, Line 117: 	
> Whitespace
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/5fe024d1_3eadaef1 
PS1, Line 133: 		</xsl:element>	
> Whitespace eol
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/df534601_d0311af1 
PS1, Line 191: 	
> Whitespace
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/98890a70_60cd291a 
PS1, Line 222: 	
> Whitespace
Done


File res/res_geolocation/geoloc_datastore.c:

https://gerrit.asterisk.org/c/asterisk/+/18696/comment/7514bda0_bd6cb209 
PS1, Line 285: datasatore
> datasatore -> datastore
Done


File res/res_geolocation/geoloc_doc.xml:

https://gerrit.asterisk.org/c/asterisk/+/18696/comment/8b5b19bf_e229bf32 
PS1, Line 141: 						<para>The specification of this parameter will cause a 
> eol whitespace
Done


File res/res_geolocation/geoloc_eprofile.c:

https://gerrit.asterisk.org/c/asterisk/+/18696/comment/a43831b7_76568697 
PS1, Line 390: 	dup = ast_strdupa(ast_str_buffer(buf));
> This appears to dupe the string just for debug/scope logging. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/2e1c9218_87980722 
PS1, Line 430: 	dup = ast_strdupa(ast_str_buffer(buf));
> Same here. Using an RAII_VAR on buf should avoid the string copy.
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/94702d67_51e29ee7 
PS1, Line 845: //		geoloc_eprofile_unload();
> Seems like this line should not be commented out?

There's a reason for that.  It segfaults when it tries to free the first xslt and I'm not sure why.  It's on my list to investigate.


File res/res_geolocation/pidf_to_eprofile.xslt:

https://gerrit.asterisk.org/c/asterisk/+/18696/comment/9fc8432a_69c27957 
PS1, Line 19: 	
> Whitespace
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/dc767147_bf0edd32 
PS1, Line 27: 	
> Whitespace
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/67d0b086_7d289984 
PS1, Line 30: -->	
> Whitespace
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/5a6b79b4_afb82167 
PS1, Line 34: cound
> s/cound/could
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/5f1e981e_15077ba1 
PS1, Line 39: 	"dm:device" would match "pdm:device" in the document. 
> whitespace
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/a41efe4f_8eed1429 
PS1, Line 41: 	
> Whitespace
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/e6d35b00_188f8872 
PS1, Line 45: 	
> Whitespace
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/0abbb4f3_622f0a34 
PS1, Line 50: 		
> Whitespace
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/862142b8_855100aa 
PS1, Line 134: 		
> Whitespace
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/54b4aae1_67ec6f97 
PS1, Line 156: 	
> Whitespace
Done


https://gerrit.asterisk.org/c/asterisk/+/18696/comment/9b4ab152_90e54adb 
PS1, Line 211: 	
> Whitespace
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18696
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ibfde963121b1ecf57fd98ee7060c4f0808416303
Gerrit-Change-Number: 18696
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 07 Jul 2022 13:04:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220707/e81f89b5/attachment-0001.html>