<p> Attention is currently required from: George Joseph. </p>
<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18696">View Change</a></p><p>24 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/geolocation.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/be3355b3_4a1e82dd">Patch Set #1, Line 183:</a> <code style="font-family:monospace,monospace">propogated</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/propogated/propagated</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/4aa7e69a_c5686753">Patch Set #1, Line 186:</a> <code style="font-family:monospace,monospace">propogated</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/propogated/propagated</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_geolocation/eprofile_to_pidf.xslt:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/c415aac4_4e3452eb">Patch Set #1, Line 12:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/65160aac_3e4704d4">Patch Set #1, Line 91:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/a3b1f9bd_f2b9d56e">Patch Set #1, Line 97:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/b3665013_dc670491">Patch Set #1, Line 117:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/27ed3ee8_1bb06956">Patch Set #1, Line 133:</a> <code style="font-family:monospace,monospace"> </xsl:element> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Whitespace eol</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/91322000_8a6a438c">Patch Set #1, Line 191:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/791cf58a_245e0135">Patch Set #1, Line 222:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Whitespace</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_geolocation/geoloc_doc.xml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/18d486db_d7d77c33">Patch Set #1, Line 141:</a> <code style="font-family:monospace,monospace"> <para>The specification of this parameter will cause a </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">eol whitespace</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_geolocation/geoloc_eprofile.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/b87380c0_054cde6c">Patch Set #1, Line 390:</a> <code style="font-family:monospace,monospace"> dup = ast_strdupa(ast_str_buffer(buf));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This appears to dupe the string just for debug/scope logging. Could probably avoid the string copy if you used a RAII_VAR on buf.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/69cde760_1014c79e">Patch Set #1, Line 430:</a> <code style="font-family:monospace,monospace"> dup = ast_strdupa(ast_str_buffer(buf));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here. Using an RAII_VAR on buf should avoid the string copy.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/625f57f8_660c69b1">Patch Set #1, Line 845:</a> <code style="font-family:monospace,monospace">// geoloc_eprofile_unload();</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Seems like this line should not be commented out?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_geolocation/pidf_to_eprofile.xslt:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/06b57033_76f2d096">Patch Set #1, Line 19:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/d1e47e9d_39d5c0e6">Patch Set #1, Line 27:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/a36b6907_d3cc31d9">Patch Set #1, Line 30:</a> <code style="font-family:monospace,monospace">--> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/d44b9413_417c4ba8">Patch Set #1, Line 34:</a> <code style="font-family:monospace,monospace">cound</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/cound/could</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/4b23c378_33913be3">Patch Set #1, Line 39:</a> <code style="font-family:monospace,monospace"> "dm:device" would match "pdm:device" in the document. </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/2d7d46d2_b6e5f9ac">Patch Set #1, Line 41:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/63ed226f_d872f5e0">Patch Set #1, Line 45:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/7cc19bb5_5ec341fd">Patch Set #1, Line 50:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/9a12db44_6afed1f6">Patch Set #1, Line 134:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/b4cdecda_4883e71a">Patch Set #1, Line 156:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18696/comment/6c4ffabf_95c2bf04">Patch Set #1, Line 211:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Whitespace</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18696">change 18696</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18696"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Ibfde963121b1ecf57fd98ee7060c4f0808416303 </div>
<div style="display:none"> Gerrit-Change-Number: 18696 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-CC: Stanislav Abramenkov <stas.abramenkov@gmail.com> </div>
<div style="display:none"> Gerrit-Attention: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 06 Jul 2022 21:38:36 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>