[Asterisk-code-review] app_queue: Fix hint updates for included contexts (asterisk[master])

N A asteriskteam at digium.com
Mon Sep 6 10:14:34 CDT 2021


Attention is currently required from: Sean Bright.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16411 )

Change subject: app_queue: Fix hint updates for included contexts
......................................................................


Patch Set 6:

(1 comment)

File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/16411/comment/dcc1f87d_375d6ce4 
PS5, Line 2652: 			unsigned short int context_found = 0;
> As much as I want to know why an unsigned short is needed here... […]
Yeah, true.
My thinking was I only need a 0 or 1, which is unsigned, and I only need a short which I think is one byte in memory instead of two (?). Not sure off the top of my head, but I was trying to use the smallest datatype that made sense.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16411
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8caf2f8da8157ef3d9ea71a8568c1eec95592b78
Gerrit-Change-Number: 16411
Gerrit-PatchSet: 6
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Mon, 06 Sep 2021 15:14:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210906/30b3107e/attachment-0001.html>


More information about the asterisk-code-review mailing list