[Asterisk-code-review] app_queue: Fix hint updates for included contexts (asterisk[master])

Sean Bright asteriskteam at digium.com
Mon Sep 6 09:56:02 CDT 2021


Attention is currently required from: N A.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16411 )

Change subject: app_queue: Fix hint updates for included contexts
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/16411/comment/38d658e9_af0c4471 
PS5, Line 2652: 			unsigned short int context_found = 0;
As much as I want to know why an unsigned short is needed here...

You can drop this and just use the existing 'found' variable to set when to break out of the loop.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16411
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8caf2f8da8157ef3d9ea71a8568c1eec95592b78
Gerrit-Change-Number: 16411
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 06 Sep 2021 14:56:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210906/834fa5d0/attachment.html>


More information about the asterisk-code-review mailing list