[Asterisk-code-review] app_queue: Fix hint updates for included contexts (asterisk[master])

[George Joseph]

Attention is currently required from: Sean Bright, N A.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16411 )

Change subject: app_queue: Fix hint updates for included contexts
......................................................................


Patch Set 7: Code-Review-1

(3 comments)

File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/16411/comment/c6e848a9_08e41f7b 
PS7, Line 2658: 
This logic only goes one level down from the state_context.  Are you not concerned about anything deeper?  If you are, you'll need to move the include walk to its own function and call it recursively.


https://gerrit.asterisk.org/c/asterisk/+/16411/comment/b87f6e9e_f1294c09 
PS7, Line 2659: 				while ((c = ast_walk_contexts(c))) {
Why not just use ast_context_find()?  It's much faster than walking them since it'll use the internal hashtable.


https://gerrit.asterisk.org/c/asterisk/+/16411/comment/853dc74a_c9ce38fd 
PS7, Line 2663: 						for (idx = 0; idx < ast_context_includes_count(c); idx++) {
ast_walk_context_includes() maybe?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16411
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8caf2f8da8157ef3d9ea71a8568c1eec95592b78
Gerrit-Change-Number: 16411
Gerrit-PatchSet: 7
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 09 Sep 2021 12:36:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210909/2db167a2/attachment.html>