[Asterisk-code-review] app_queue: Fix hint updates for included contexts (asterisk[master])

N A asteriskteam at digium.com
Sun Sep 5 13:25:10 CDT 2021


N A has uploaded a new patch set (#2). ( https://gerrit.asterisk.org/c/asterisk/+/16411 )

Change subject: app_queue: Fix hint updates for included contexts
......................................................................

app_queue: Fix hint updates for included contexts

Previously, if custom hints were used with the hint:
format in app_queue, when device state changes occured,
app_queue would only do a literal string comparison of
the context used for the hint in app_queue and the context
of the hint which just changed state. This caused hints
to not update and become stale if the context associated
with the agent included the context which actually changes
state, essentially completely breaking device state for
any such agents defined in this manner.

This fix adds an additional check to ensure that included
contexts are also compared against the context which changed
state, so that the behavior is correct no matter whether the
context is specified to app_queue directly or indirectly.

ASTERISK-29578 #close

Change-Id: I8caf2f8da8157ef3d9ea71a8568c1eec95592b78
---
M apps/app_queue.c
1 file changed, 31 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/11/16411/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16411
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8caf2f8da8157ef3d9ea71a8568c1eec95592b78
Gerrit-Change-Number: 16411
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-CC: Friendly Automation
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210905/18329165/attachment.html>


More information about the asterisk-code-review mailing list