[Asterisk-code-review] app_read: Fix custom terminator functionality regression (asterisk[master])

[Kevin Harwell]

Attention is currently required from: N A.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16633 )

Change subject: app_read: Fix custom terminator functionality regression
......................................................................


Patch Set 1:

(1 comment)

File apps/app_read.c:

https://gerrit.asterisk.org/c/asterisk/+/16633/comment/5bdff6eb_025c93d1 
PS1, Line 253: 					if (terminator && strchr(terminator, tmp[x-1])) {
If '#' is default (what was checked for in the original code) then when terminator==NULL shouldn't this check for tmp[x-1] == '#'?

As is, this skips this check if terminator==NULL, which is the behavior you want if terminator=""? Maybe I have stuff backwards?

Maybe 'if (!terminator || strchr(terminator, tmp[x-1])'?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16633
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9b6b72196dd04f5b1e0ab5aa1b0adf627725e086
Gerrit-Change-Number: 16633
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 26 Oct 2021 23:45:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211026/c156a00e/attachment.html>