[Asterisk-code-review] app_read: Fix custom terminator functionality regression (asterisk[master])

[N A]

Attention is currently required from: Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16633 )

Change subject: app_read: Fix custom terminator functionality regression
......................................................................


Patch Set 1:

(1 comment)

File apps/app_read.c:

https://gerrit.asterisk.org/c/asterisk/+/16633/comment/e4fc1a3c_9e11ab7a 
PS1, Line 253: 					if (terminator && strchr(terminator, tmp[x-1])) {
> If '#' is default (what was checked for in the original code) then when terminator==NULL shouldn't t […]
Yeah, you're right, I didn't realize testing with no arg2 used the sound file branch rather than the indications branch, so I missed that.

The line above as written terminates on anything with no args, so it never reads anything at all. But, I'm realizing now that using "#" would be okay for that case. S_OR doesn't distinguish between NULL and "", but app.c needs to. In this app_read branch, it should be okay.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16633
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9b6b72196dd04f5b1e0ab5aa1b0adf627725e086
Gerrit-Change-Number: 16633
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 27 Oct 2021 00:02:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211026/270f4fb6/attachment-0001.html>