<p> Attention is currently required from: N A. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/16633">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File apps/app_read.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16633/comment/5bdff6eb_025c93d1">Patch Set #1, Line 253:</a> <code style="font-family:monospace,monospace">                                    if (terminator && strchr(terminator, tmp[x-1])) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If '#' is default (what was checked for in the original code) then when terminator==NULL shouldn't this check for tmp[x-1] == '#'?</p><p style="white-space: pre-wrap; word-wrap: break-word;">As is, this skips this check if terminator==NULL, which is the behavior you want if terminator=""? Maybe I have stuff backwards?</p><p style="white-space: pre-wrap; word-wrap: break-word;">Maybe 'if (!terminator || strchr(terminator, tmp[x-1])'?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16633">change 16633</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16633"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9b6b72196dd04f5b1e0ab5aa1b0adf627725e086 </div>
<div style="display:none"> Gerrit-Change-Number: 16633 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-CC: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 26 Oct 2021 23:45:36 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>