[Asterisk-code-review] res_pjsip_callerid: Fix OLI parsing (asterisk[master])

N A asteriskteam at digium.com
Mon Oct 25 18:30:40 CDT 2021


Attention is currently required from: N A.
Hello Kevin Harwell, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/16632

to look at the new patch set (#3).

Change subject: res_pjsip_callerid: Fix OLI parsing
......................................................................

res_pjsip_callerid: Fix OLI parsing

Fix parsing of ANI2/OLI information, since it was previously
parsing the user, when it should have been parsing other_param.

Also improves the parsing by using pjproject native functions
rather than trying to parse the parameters ourselves like
chan_sip did. A previous attempt at this caused a crash, but
this works correctly now.

ASTERISK-29703 #close

Change-Id: I8f3c79032d9ea1a21d16f8e11f22bd8d887738a1
---
M res/res_pjsip_caller_id.c
1 file changed, 18 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/32/16632/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16632
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8f3c79032d9ea1a21d16f8e11f22bd8d887738a1
Gerrit-Change-Number: 16632
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211025/09163ec3/attachment.html>


More information about the asterisk-code-review mailing list