[Asterisk-code-review] res_pjsip_callerid: Fix OLI parsing (asterisk[master])

[N A]

Attention is currently required from: Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16632 )

Change subject: res_pjsip_callerid: Fix OLI parsing
......................................................................


Patch Set 3:

(1 comment)

File res/res_pjsip_caller_id.c:

https://gerrit.asterisk.org/c/asterisk/+/16632/comment/124e4cc3_b03ccd47 
PS2, Line 152: 	oli2 = pjsip_param_find(&from->other_param, &oli_str2);
             : 	oli3 = pjsip_param_find(&from->other_param, &oli_str3);
             : 
             : 	if (oli1) {
             : 		ast_copy_pj_str(oli, &oli1->value, sizeof(oli));
             : 	} else if (oli2) {
             : 		ast_copy_pj_str(oli, &oli2->value, sizeof(oli));
             : 	} else if (oli3) {
             : 		ast_copy_pj_str(oli, &oli3->value, sizeof(oli));
> Not a huge deal but since you only use 2 if 1 is not avail, and 3 if 2 is not avail you could wait t […]
Makes sense, I've ordered the headers from most typical to least typical anyways, so most of the time, it should match on the first one if it gets a match.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16632
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8f3c79032d9ea1a21d16f8e11f22bd8d887738a1
Gerrit-Change-Number: 16632
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 25 Oct 2021 23:32:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211025/bf686d8f/attachment.html>