[Asterisk-code-review] res_pjsip_callerid: Fix OLI parsing (asterisk[master])

[Kevin Harwell]

Attention is currently required from: N A.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16632 )

Change subject: res_pjsip_callerid: Fix OLI parsing
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

Patchset:

PS2: 
A minor optional improvement if you so choose. I'll +1 for now.


File res/res_pjsip_caller_id.c:

https://gerrit.asterisk.org/c/asterisk/+/16632/comment/4462a268_e60ae81d 
PS2, Line 152: 	oli2 = pjsip_param_find(&from->other_param, &oli_str2);
             : 	oli3 = pjsip_param_find(&from->other_param, &oli_str3);
             : 
             : 	if (oli1) {
             : 		ast_copy_pj_str(oli, &oli1->value, sizeof(oli));
             : 	} else if (oli2) {
             : 		ast_copy_pj_str(oli, &oli2->value, sizeof(oli));
             : 	} else if (oli3) {
             : 		ast_copy_pj_str(oli, &oli3->value, sizeof(oli));
Not a huge deal but since you only use 2 if 1 is not avail, and 3 if 2 is not avail you could wait to find those params if the previous is not available.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16632
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8f3c79032d9ea1a21d16f8e11f22bd8d887738a1
Gerrit-Change-Number: 16632
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 25 Oct 2021 23:24:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211025/8cbcf457/attachment-0001.html>