[Asterisk-code-review] func_evalexten: Extension evaluation function (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A, Sarah Autumn, George Joseph.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16075 )

Change subject: func_evalexten: Extension evaluation function
......................................................................


Patch Set 12:

(1 comment)

File funcs/func_evalexten.c:

https://gerrit.asterisk.org/c/asterisk/+/16075/comment/4c4e244d_eca462a9 
PS12, Line 157: 	pbx_substitute_variables_helper(chan, tmpbuf, buf, len);
> The only thing that occurs to me is introduce another type of lock here, that isn't a full channel l […]
Introducing more locking is never a good idea, in particular involving channels. And no - I don't think anything using the API call would report a failure because to it, it would be successful. The value just gets overwritten later. It would be as if the ast_async_goto never happened.

Do any other applications or functionality in the dialplan alter the context/extension/priority like this? (Store it and then restore)

Checking after you reacquire the channel lock that the context/extension/priority are what you set them to earlier is probably an option.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16075
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iad81019689674c9f4ac77d235f5d7234adbb1432
Gerrit-Change-Number: 16075
Gerrit-PatchSet: 12
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 10 Nov 2021 16:44:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211110/4074042b/attachment.html>