[Asterisk-code-review] func_evalexten: Extension evaluation function (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Sarah Autumn, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16075 )

Change subject: func_evalexten: Extension evaluation function
......................................................................


Patch Set 12:

(1 comment)

File funcs/func_evalexten.c:

https://gerrit.asterisk.org/c/asterisk/+/16075/comment/335ee267_b4f2b5bf 
PS12, Line 157: 	pbx_substitute_variables_helper(chan, tmpbuf, buf, len);
> Introducing more locking is never a good idea, in particular involving channels. […]
Well I think George had mentioned that app_stack and some other core modules work in similar ways. I haven't read into it too much.

As a matter of fact, I did write a module over the week and basically it does stuff that is similar to what this is doing (in that it needs to fetch and evaluate the data at an extension), so I was considering that maybe get_extension_data should be an ast_ public API and the core logic should be a single core function that could be called from any module. For now, I just duplicated all the logic in that module.

What do you mean exactly by checking when we restore? We know that it'd be the same as before, since we saved it while the channel was locked. We wouldn't know from EVAL_EXTEN that an async goto had happened and failed, if I understand your point right.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16075
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iad81019689674c9f4ac77d235f5d7234adbb1432
Gerrit-Change-Number: 16075
Gerrit-PatchSet: 12
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 10 Nov 2021 16:49:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211110/1595ba7b/attachment-0001.html>