[Asterisk-code-review] func_evalexten: Extension evaluation function (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Sarah Autumn, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16075 )

Change subject: func_evalexten: Extension evaluation function
......................................................................


Patch Set 12:

(1 comment)

File funcs/func_evalexten.c:

https://gerrit.asterisk.org/c/asterisk/+/16075/comment/c0b550d0_4ee50494 
PS12, Line 157: 	pbx_substitute_variables_helper(chan, tmpbuf, buf, len);
> I don't, this is uncharted territory to me.
The only thing that occurs to me is introduce another type of lock here, that isn't a full channel lock. If the lock is already held, however, that would not actually preclude anything. However, an async goto and other such operations will wait until that lock is released before continuing. A full channel lock is too restrictive and untenable here. Not sure if this would fit into the way that any existing locks operate.

Also, when you say the async goto will "silently" fail, it will still report failure, no? e.g. if ChannelRedirect fails to redirect the channel, CHANNELREDIRECTSTATUS will report failure. In that case, it's not like we don't know.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16075
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iad81019689674c9f4ac77d235f5d7234adbb1432
Gerrit-Change-Number: 16075
Gerrit-PatchSet: 12
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 10 Nov 2021 16:38:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211110/b731768f/attachment.html>