[Asterisk-code-review] func_dtmfstore: New function (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16070 )

Change subject: func_dtmfstore: New function
......................................................................


Patch Set 1:

(4 comments)

File funcs/func_dtmfstore.c:

https://gerrit.asterisk.org/c/asterisk/+/16070/comment/8a51802a_da27d2e2 
PS1, Line 62: =CDR(digits)
> I don't understand this example. […]
This dictates that any digits dialed in the specified direction will by appended to this variable. So in this case, since I want them in a CDR record (custom column), I just specify this column and when the call is over, it will automatically be there with no further processing required.
A non-CDR variable could be used, but I think CDR variables would be the most useful case.


https://gerrit.asterisk.org/c/asterisk/+/16070/comment/0cdc9bcf_2392f637 
PS1, Line 150: ast_strdupa
> You don't need to strdup these. […]
Ack


https://gerrit.asterisk.org/c/asterisk/+/16070/comment/55da63fa_af292613 
PS1, Line 152: ast_strdupa
> Same
Ack


https://gerrit.asterisk.org/c/asterisk/+/16070/comment/4684e9df_21f9ccc5 
PS1, Line 168: 			remove_dtmf_store(chan); /* reached max digit count, stop now */
> Do you really want to remove the store?  If you do, you won't be able to get the existing digits.
The digits go directly into the variable during the callback, so if maximum # of digits is reached (e.g., the database column only stores X digits), then we may as well get rid of this entirely at this point so it won't do anything useful for us afterwards. Destroying the framehook doesn't modify the collected digits because they are not stored as part of it, but in the specified variable.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16070
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I51aa93fc9507f7636ac44806c4420ce690423e6f
Gerrit-Change-Number: 16070
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 23 Jun 2021 20:49:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210623/bef32009/attachment-0001.html>