[Asterisk-code-review] func_dtmfstore: New function (asterisk[master])

[George Joseph]

Attention is currently required from: N A, Joshua Colp.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16070 )

Change subject: func_dtmfstore: New function
......................................................................


Patch Set 1: Code-Review-1

(5 comments)

Patchset:

PS1: 
I think this should be an application, not a function.


File funcs/func_dtmfstore.c:

https://gerrit.asterisk.org/c/asterisk/+/16070/comment/730aa1b9_bde615aa 
PS1, Line 62: =CDR(digits)
I don't understand this example.  CDR(digits)?


https://gerrit.asterisk.org/c/asterisk/+/16070/comment/2bffb1c8_ab8fdf9f 
PS1, Line 150: ast_strdupa
You don't need to strdup these.  Just set varname = framedata->rx_var


https://gerrit.asterisk.org/c/asterisk/+/16070/comment/bd63c2db_5d2532ac 
PS1, Line 152: ast_strdupa
Same


https://gerrit.asterisk.org/c/asterisk/+/16070/comment/371355eb_74f2938a 
PS1, Line 168: 			remove_dtmf_store(chan); /* reached max digit count, stop now */
Do you really want to remove the store?  If you do, you won't be able to get the existing digits.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16070
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I51aa93fc9507f7636ac44806c4420ce690423e6f
Gerrit-Change-Number: 16070
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 23 Jun 2021 13:40:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210623/d94ffde8/attachment.html>