[Asterisk-code-review] func_dtmfstore: New function (asterisk[master])

N A asteriskteam at digium.com
Wed Jun 23 15:54:34 CDT 2021


Attention is currently required from: Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16070 )

Change subject: func_dtmfstore: New function
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> I think this should be an application, not a function.
Whoops, missed this one.
So something like SetDTMFStore(direction,var,maxdigits) basically?
I thought this seemed more functiony, but I don't care either way and could certainly do that.
One consideration is this could be added via an AMI Setvar, or manipulated in other ways, presumably but that would not be possible with an application, since the channel needs to actually go there.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16070
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I51aa93fc9507f7636ac44806c4420ce690423e6f
Gerrit-Change-Number: 16070
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 23 Jun 2021 20:54:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210623/8614274b/attachment.html>


More information about the asterisk-code-review mailing list