<p> Attention is currently required from: N A, Joshua Colp. </p>
<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16070">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16070?tab=comments">Patch Set #1:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">I think this should be an application, not a function.<br></p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File funcs/func_dtmfstore.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16070/comment/730aa1b9_bde615aa">Patch Set #1, Line 62:</a> <code style="font-family:monospace,monospace">=CDR(digits)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't understand this example.  CDR(digits)?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16070/comment/2bffb1c8_ab8fdf9f">Patch Set #1, Line 150:</a> <code style="font-family:monospace,monospace">ast_strdupa</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You don't need to strdup these.  Just set varname = framedata->rx_var</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16070/comment/bd63c2db_5d2532ac">Patch Set #1, Line 152:</a> <code style="font-family:monospace,monospace">ast_strdupa</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16070/comment/371355eb_74f2938a">Patch Set #1, Line 168:</a> <code style="font-family:monospace,monospace">                     remove_dtmf_store(chan); /* reached max digit count, stop now */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Do you really want to remove the store?  If you do, you won't be able to get the existing digits.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16070">change 16070</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16070"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I51aa93fc9507f7636ac44806c4420ce690423e6f </div>
<div style="display:none"> Gerrit-Change-Number: 16070 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-CC: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 23 Jun 2021 13:40:06 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>