[Asterisk-code-review] pbx_builtins: Corrects SayNumber warning (asterisk[16])

[N A]

Attention is currently required from: Sean Bright, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16083 )

Change subject: pbx_builtins: Corrects SayNumber warning
......................................................................


Patch Set 2:

(1 comment)

File main/pbx_builtins.c:

https://gerrit.asterisk.org/c/asterisk/+/16083/comment/71af0d1a_97a1d21f 
PS2, Line 1273: 	interrupt_string = pbx_builtin_getvar_helper(chan, "SAY_DTMF_INTERRUPT");
> > The issue happens if the hangup is during ast_say_number, which is line 1300, after this point, so […]
Yeah, the goal here is not the channel is not hanging up, it's to not output a confusing warning for no reason just because the channel was hung up while the digits are streamed, so to accomplish that it would need to be located after the ast_say_number, to determine if we should emit an error or not. Before ast_say_number, I'm thinking all that executes so quickly that if it got there, the channel was at least up then. The place where it's likely to not be up is at the end.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16083
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ieea4a67301c6ea83bbc7690c1d4808d79a704594
Gerrit-Change-Number: 16083
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 10 Jun 2021 17:53:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210610/32a700ef/attachment-0001.html>